<@412975656586969118> Hi! I'm excited by the new i...
# │firmware-dev
c
@svenrademakers Hi! I'm excited by the new interfaces migration script! I had just 2 items of feedback: 1. The migration logic should probably trigger on
[ "$is_new" -eq 0 ] && [ "$has_eth0" -eq 1 ]
(not
||
) since it's conceivable that some user would want to keep the eth0 declaration around "in case of" downgrade to 2.0.x. (I believe this will simply do nothing on 2.1.x) 2. Should it go in S00dsa instead of preinit? This keeps preinit more readable for users trying to understand the boot process.
3 Views